On OSX revert back to terminal hack to avoid a readline bug #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
haha, node is so portable!!, sucks that windows terminals dont handle \r correctly |
tj
added a commit
that referenced
this pull request
Sep 19, 2012
On OSX revert back to terminal hack to avoid a readline bug
|
I know all too well ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into an issue with one of my apps, I believe it's a readline/process issue, but this reverts the
ctrl+uclearing back to\ronly for OSX.This still works on Windows and everywhere else, but this fixes an issue when you have several child processes sharing the same stdin, the
ctrl+uactually looks to be getting called once per child that's bound and not just once. So the progress bar will write one line and delete 10 (one per child) before it..Totally screwy and will take a ton of debugging, but this works for now.